frontend icon indicating copy to clipboard operation
frontend copied to clipboard

Add icon to header to link to User Guide

Open michaelchadwick opened this issue 1 year ago • 6 comments

Fixes ilios/ilios#3759.

Created new UserGuideLink component that displays an icon to click that opens the Ilios User Guide in a new window. It has translations for the <svg><title> element, and a simple component test.

michaelchadwick avatar May 10 '24 22:05 michaelchadwick

neat - any chance of making the icon a little bit bigger? 20% or so - that's my $.02, which could get vetoed - looks good though all in all

dartajax avatar May 10 '24 22:05 dartajax

@dartajax No problem on the size change. I also noticed I need to adjust it for smaller screens, so I'll fix that, too.

michaelchadwick avatar May 10 '24 23:05 michaelchadwick

Some alternatives for icons:

  • Book: https://fontawesome.com/icons/book?f=classic&s=regular
  • Info: https://fontawesome.com/icons/circle-info?f=classic&s=regular
  • Life Ring: https://fontawesome.com/icons/life-ring?f=classic&s=regular
  • Clipboard Question: https://fontawesome.com/icons/clipboard-question?f=classic&s=regular

@dartajax What say you?

michaelchadwick avatar May 15 '24 16:05 michaelchadwick

Might be the "regular" I don't love. We have a license for everything.

jrjohnson avatar May 15 '24 16:05 jrjohnson

Oddly, though, the <FaIcon> component had no hook to use fa-regular, only fa-solid and fa-brands, so that is why I made the change to the component in this PR.

Regardless, I ended up using the fa-solid version, anyway, but just changed the color of the svg to be white.

michaelchadwick avatar May 15 '24 16:05 michaelchadwick

Code looks good, assigning to @dartajax for visual review and merging.

jrjohnson avatar Jul 18 '24 18:07 jrjohnson

Percy just needs approval of the changes @dartajax, because this header is on every page it's a lot of changes, but still worth checking through I think.

jrjohnson avatar Jul 19 '24 18:07 jrjohnson