Johannes Rieken

Results 171 comments of Johannes Rieken

Still seeing this

When I toggle back and worth I do see an extra padding at the bottom of the view port https://user-images.githubusercontent.com/1794099/139039543-2825bcca-c86b-4ca2-9c28-fc306f7735d9.mov

still seeing this

This happens because inlay hint have their own hover which are anchored on a `ForeignElement`. The diagnostics hover explicitly checks for that and [bails out](https://github.com/microsoft/vscode/blob/29b117216229e4cfdd3d95fd4cb83ad4c37529fc/src/vs/editor/contrib/hover/browser/markdownHoverParticipant.ts#L64). @alexdima Would be OK to...

@Tyriar Please update this issue with a real code snippet that allows to reproduce this, @lramos15 please update this issue with what you have tried. Thanks

Something like this only gives a squiggle for the return value, not the arguments or anything with inline hints. To clarify, this will only work for squiggles that spawn across...

Yeah, whenever a cell is removed we emit a `onDidCloseTextDocument`-event. Your fix looks OK, tho it builds on the "internal" cell uri structure. We have also proposed `TextDocument#notebook` (see https://github.com/microsoft/vscode/issues/102091)...

> Alternatively, keep the feature in place but don't allow it to delay the popup - just populate it dynamically when the suggestions become available. That's how it should work...

This is now fixed, e.g has changes. Typing "/explain some query" now stays within inline but the request can be moved to panel chat anytime, e.g after or during it...