Johannes Rieken

Results 171 comments of Johannes Rieken

> How does the typescript extension solve this problem to support the Web IDE? This is being worked on. Today, the TypeScript web extension is more or less single file,...

> @jrieken If I understand correctly, I need to migrate from TS language service API to tsserver after tsserver supports virtual file system, or I have to implement virtual file...

> of language server will cause performance issues, it seems not proven in tsserver yet and I have to try. I do something similar with [vscode-anycode](https://github.com/microsoft/vscode-anycode) and it seems to...

cc @OsvaldoRosado we somehow missed that when we started webpack'ing appinsights. Biggest question is what current consequences this has?

> We can add custom metadata, however now we need to ensure the serializer is updated to ignore such custom metadata 👍 Yeah, way to go. The `id` seems like...

* `id` is useful to find ext host output from renderer (command, actions, etc) * tho `id` is random and doesn't fit into model as nicely * think about exposing...

@rebornix According to our product.json-based allow listing it isn't. Is data wrangler an extension or are they a fork? In the latter case we should be fine

Thanks @sadasant - all should be good because it isn't allow-listed and therefore cannot use the API anyways

> this occurs just for changing uppercase or lowercase in the file name. On windows and mac (which default to being case-insensitive) we don't treat this as a "true" rename,...

Looks like [resolve](https://github.com/microsoft/vscode/blob/28c330caf07b7f16abc8826875c2ca493f7edfd5/src/vs/editor/contrib/links/browser/getLinks.ts#L50) should be called not just on open but also on hover