John Gemignani

Results 373 comments of John Gemignani

This task will be a project for our interns to tackle.

@rafsun42 If you look at what they look through, you'll see that they are not the same. **colNameToVar** is for finding a column name and creating a variable from it....

@rafsun42 I have reviewed the patch and added my comments. Once corrected, the patch looks good to go.

@ishaan812 `age_prepare_string` is meant to be called by a driver or something passing `cstrings`. ``` CREATE FUNCTION ag_catalog.age_prepare_cypher(cstring, cstring) RETURNS boolean LANGUAGE c STABLE PARALLEL SAFE AS 'MODULE_PATHNAME'; ``` ```...

@MironAtHome This command was added to fix a very specific security issue in the drivers. It allows the cypher() command to be parameterized and the wrapping to be separated from...

@MironAtHome Just understand that it wasn't intended nor expected to be used outside of this [security issue] context. So it may not work as expected. And, come to think of...

@ishaan812 The function resets if it isn't used immediately by the process that created it. However, I do see some issues with the logic it uses and will need to...

``` psql-16.2-5432-psql=# SELECT * FROM cypher('my_graph_name', $$ match (u) return u, vertex_stats(u) $$) as (u agtype, degree agtype); u | degree ----------------------------------------------------------------+------------------------------------------------------------------- --------------------- {"id": 281474976710657, "label": "", "properties": {}}::vertex |...

@shinyaaa You will need to rebase and force update your PR. Please see PR #2007 for more information.

@shinyaaa There appears to be an issue with the build regression for this one :( Please look into it when you have an opportunity - ![image](https://github.com/user-attachments/assets/85ca5e84-2afd-4ad1-89a3-c504fbf67342)