age icon indicating copy to clipboard operation
age copied to clipboard

Add EmitWarningsOnPlaceholders("age") (#1997)

Open shinyaaa opened this issue 1 year ago • 5 comments

Added EmitWarningsOnPlaceholders("age") to warn when an undefined GUC parameter is set for a placeholder named "age".

Warnings are issued when PostgreSQL starts and when SET statements are executed.

When PostgreSQL starts

2024-08-01 18:32:31.220 JST [2039799] WARNING: invalid configuration parameter name "age.invalid_parameter", removing it

When SET statement is executed

ERROR: invalid configuration parameter name "age.invalid_parameter"
DETAIL: "age" is a reserved prefix.

Regression tests were added.

shinyaaa avatar Aug 01 '24 09:08 shinyaaa

@shinyaaa You will need to rebase and force update your PR. Please see PR #2007 for more information.

jrgemignani avatar Aug 06 '24 14:08 jrgemignani

@shinyaaa There appears to be an issue with the build regression for this one :( Please look into it when you have an opportunity - image

jrgemignani avatar Aug 07 '24 23:08 jrgemignani

Hi @shinyaaa the regression tests are failing for PG13 and 14.

rafsun42 avatar Aug 08 '24 19:08 rafsun42

@jrgemignani @rafsun42 Sorry.

Until v14, it seems to warn only when PostgreSQL starts. Warnings in SET statements are implemented in this commit. Therefore, the regression test has been removed.

shinyaaa avatar Aug 09 '24 00:08 shinyaaa

This PR is stale because it has been open 60 days with no activity. Remove "Abondoned" label or comment or this will be closed in 14 days.

github-actions[bot] avatar Oct 15 '24 00:10 github-actions[bot]

This PR was closed because it has been stalled for further 14 days with no activity

github-actions[bot] avatar Oct 29 '24 00:10 github-actions[bot]