John Gemignani

Results 366 comments of John Gemignani

@sanchayanghosh Sorry for the delay. This would need to be added to a branch specifically for PG18 support.

@sanchayanghosh I have created **PG18_prepare** for such work. It will need to be adjusted a bit before it actually is ready, but it would be where you would apply this...

> @sanchayanghosh I have created **PG18_prepare** for such work. It will need to be adjusted a bit before it actually is ready, but it would be where you would apply...

> I removed the macro checks. Thanks to you both for reviews. I am sorry I was in middle of some other projects I couldn't check last month and got...

> @jrgemignani @MuhammadTahaNaveed > > I didn't get the option to request reviewers. I would greatly appreciate if you could review my code? Always happy to incorporate any improvements. >...

> @sanchayanghosh Regression tests fail and there's a crash in `cypher_match` regression test. Same for me. How did you build this prior to submitting it? Did it work for you?

@sanchayanghosh @MuhammadTahaNaveed Is this necessary to add to this PR? Could, should, it be its own PR? > Added a delete test to ensure that proper error message is shown.

@wen-bing This problem is usually caused by loading multiple files, or the same file, to the same label. For example, reusing the same vertices file with the same label will...

@uhayat I am okay with merging a change **where palloc0fast is replaced by palloc0**. But, we don't use version flags as stated by @shinyaaa above, so I won't approve that.