Juliette

Results 2034 comments of Juliette

@schlessera Couple of questions/observations: * You mention WPCLI shipping with its own copy of Requests. Does it use PHP_Scoper for that copy ? If not, why not ? When I...

If nothing else, you can possibly use the version constant to figure out in strategic places which version of Requests has been loaded ?

Conclusions from analyzing this issue today in a video call with @schlessera and @alpipego: The problem occurs in the following situation: > * If during a "page load", some of...

Just thinking - to make it easier to implement the above mentioned bootstrapping in projects which have to deal with mixed Requests versions, we could add a `public static Autoload::getDeprecatedClasses()`...

Oh and once you've tested this and it's okay, we may want to add it as an example in the `examples` directory ?

Some additional notes: * For use in a WP context, the actual preloading should probably be wrapped in a version check once WP has a release which includes Requests 2.x,...

@alpipego Ha, that's what I get for quickly writing out a code sample in a comment instead of a code editor 😂 I'll have a look at the PR. Thanks...

Leaving this open until @schlessera has been able to test the above with WP-CLI. Alain: please let us know how you get on & close the issue if the changes...

@schlessera Just checking in: have you had a chance to test this with WP-CLI in the mean time ?