Juliette

Results 2034 comments of Juliette

The tests show an error on PHP 5.6: > 1) Yoast\WP\SEO\Tests\Unit\Main_Test::test_surfaces > Yoast\WP\SEO\Presentations\Indexable_Post_Type_Presentation and Yoast\WP\SEO\Presentations\Archive_Adjacent define the same property ($pagination) in the composition of Yoast\WP\SEO\Presentations\Indexable_Static_Posts_Page_Presentation. This might be incompatible, to...

Nope, doesn't solve that particular one. @diedexx Let's talk that one through when you have a moment.

We - @diedexx and me - discussed the above in a call. To keep the changeset atomic - i.e. just address the original problem - the commit which moved the...

> In my DEV environment deprecations are thrown as exceptions due to other software in which Wordpress is integrated. That sounds like a problem in your dev environment. Deprecations are...

This looks to have been fixed. Should this issue be closed ?

As noted in #161, I'd strongly advise to use the `phpcompatibility/phpcompatibility-wp` dependency instead of `PHPCompatibility`.

> It's worth mentioning that as of WP 5.8.2 it looks like the current testing setup is broken due to the missing polyfills. 5.8.1 still works. Correct: the test changes...

@grappler Are you by chance looking for this write-up about it ? https://make.wordpress.org/core/2021/09/27/changes-to-the-wordpress-core-php-test-suite/ (In particular the "What does this mean for plugins/themes running integration tests based on the WP Core...

@grappler Glad it helped ;-)

I've updated the issue description to contain a list of additional tasks and an action list so we can keep track of the status of this mini-project. We'd welcome more...