Juliette
Juliette
The branch which is intended to be the new repo content & history, is now online for review: https://github.com/WPTRT/WPThemeReview/tree/feature/163-166-167-169-decouple-from-WPCS
I think we left it open at the time as the open PRs which got automatically closed haven't been updated and re-pulled yet. Still somewhere on my never-ending to-do list.....
> Is this only regarding adding menu pages, or other usages too? This should be for all usages
#### Theme check file (partially) covering this rule: https://github.com/Otto42/theme-check/blob/master/checks/admin_menu.php
Also in the handbook (related but not the same): > Use edit_theme_options capability for determining user permission to edit options, rather than rely on a role (e.g. “administrator”), or a...
In the new Theme handbook, the rule has been moved to another section: https://make.wordpress.org/themes/handbook/review/required/#options-and-settings
@dd32 As these things are in WPCS as well, I'd love to hear your voice in the discussion being had here: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/1265. (Merged) PR https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/1374 in response to https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/943 is...
Both `?:` (PHP 5.3+) usage, as well as `??` (PHP 7.0+) usage influence the minimum PHP version for a theme. If I remember correctly, the "default" presumption is that themes...
Well, the `PHPCompatibilityWP` ruleset which is included in TRTCS already does so as the minimum PHP version for that is set to `5.2`.
No need to extend the sniff, this can simply be changed from the ruleset `warning`.