Juliette
Juliette
Oh and just thinking: regarding the filtering out of minified JS/CSS files, instead of using the `bootstrap` for this, this can probably be done via a custom `Filter` class. (new...
Well, the filter could also examine the contents of files, but to be fair, PHPCS itself already does this and is a lot better at detecting and excluding minified files...
This is the rule as stated in the handbook: > Include all scripts and resources it uses rather than hot-linking. The exception to this is Google Fonts. Maybe the title...
I'm updating the PR at this moment. For the implementation of this, I have some additional questions to verify if I'm understanding this correctly and whether the sniff does what...
@joyously 1. No, it was not. If you look at the PR in #108, you can see that it used a blacklist and would only throw an error if something...
> That's the point. Everything should be a local file I know, but that doesn't mean that it is sniffable.
### Actions needed - [ ] It would be really helpful for finishing this off to have code samples of both things which should be flagged as well as things...
Themes normally support multiple versions of WordPress, so while the minimum PHP requirement for WP 5.2 is now PHP 5.6.20, for WP < 5.2, it still is PHP 5.2.6. The...
> Is there a - dirty - workaround to support only PHP 5.3? @szepeviktor You mean for the sniffs to run on PHP 5.3 or for your code to be...
@timelsass Welcome! I'll try and review your sniff over the next few days, but for now, I just want to leave some comments for you to think about. * Can...