Juliette
Juliette
Just out of interest: why allow a toplevel menu ? As there is a `Theme` menu already, wouldn't it make more sense to only allow the Theme to add submenu...
Upstream issue: https://github.com/squizlabs/PHP_CodeSniffer/issues/1273
> I personally don't have anything against it. @jrfnl what was the idea behind this sniff? @dingo-d By the looks of it, the sniff itself hasn't changed, it's just the...
I wonder if it would be a better idea to add these sniffs to WPCS in general and then include them from WPTRT ? Or alternatively add them to the...
@dingo-d FYI: The Security standard needs some work (and a new release) before it could be considered for inclusion, but it's something to keep an eye on for the future...
No release planning known to me, though I am trying to help box the project into shape, so will let you know when I know more. Once sniffs are written...
> The text domain in style.css needs to be the theme slug as well. It would be good if this could be checked at the same time I think. Though...
> The second group I didn't add because you mentioned it in the comment in the PR It didn't belong in the other PR as it would change the functionality...
Basically, it's about decision points: For the other PR the decision was supposed to be "should we update the minimum WPCS version to 2.2.0 ?". By having the extra datetime...
@grappler Why wait for the back-merge ? A new `WordPress.Theme.AlternativeFunctions` or `WordPress.Theme.DiscouragedFunctions` sniff can be added any time. As these are quite Theme specific function, that seems most appropriate to...