Juliette
Juliette
@johnbillion Changes to the coding standards need to be proposed on Make.
Indeed, but that was _after_ we were told - in no uncertain terms - that any changes had to go via a proposal on Make. There is also no formal...
Understood. It may still be worth it to check for a hard-coded value which evaluates to an integer as the second/`$skip` argument ? Between the `AbstractFunctionCallParameterSniff` and the `TokenGroup::isNumber()` helper,...
> If we write a sniff to check for an int, it won't _technically_ be correct and might even be wrong with future PHP changes to that signature. While I...
@afilina No, sorry, I'd overlooked that I'd not added the label yet.
@afilina Thanks for this initial research, but I have a feeling this needs a deeper layer of research still. > // Only literals can be assigned in this context (anything...
> > The eventual sniff should not flag static variable declarations which are still invalid > > Other sniffs report new syntax on old versions as invalid. That's where I...
Just read through the RFC myself and while I have a feeling we may well be able to detect recursion, I agree with your assessment that it doesn't add any...
Same remarks apply as I left in my comment in #1977.
Some background: the reason that this was not addressed so far is that PHPCompatibility will only be able to detect this reliably in a very small subset of cases and...