Juliette
Juliette
> Looking into the failing quick test build. I'm not seeing any failures ?
> Should these sniffs treat namespace-prefixed function calls that mirror the name of global functions they check as different functions and treat them accordingly? In my opinion: yes. Reason for...
See my reply in the other issue as it also applies here: https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/1302#issuecomment-3482906117
Valid point. On the one hand, some of these could probably be prevented already by making the regex more specific with a (negative) look-behind. On the other hand, the regex...
> I believe we explored this a bit together in one of our calls, and were not able to find a way to run the utils tests together with the...
I've updated the PR description to include a reference to an issue I opened about tests for utility methods a couple of years back - #2272. As per that issue,...
@dingo-d Thanks for your input. I'd be happy to go that route, though someone else will have to do the Make post (but can use the text from the commit...
Added one more test (ParseError3).
> With that in mind, I suggest that, in preparation to support PHPCS 4.0, we update WordPress.Utils.I18nTextDomainFixer to stop checking and fixing headers in CSS files. This seems to me...
> my understanding is that we don't need to change the sniff when adding support for PHPCS 4.x and when support for PHPCS 3.x is dropped, we update the sniff...