Juliette

Results 2034 comments of Juliette

> And I get the impression that clicking the "Set Done" button has no effect whatsoever. I wonder if this part of the issue may be due to some of...

Thanks for the update @afinetooth ! I became aware of the maintenance quite quickly when it started, the status page told me what was going on, so I wasn't concerned...

@ocean90 Thanks for reporting this. A lot of the WPCS sniffs at this moment are not adapted yet to handle namespaced code correctly in all situations. Fixing this for this...

@theseer Good point. As PHP itself doesn't use the dash for their releases, I had the mistaken idea that the dash was optional.

Wasn't intended as one. Might be good to document somewhere that tags need to comply with semver ?

> My mistake, thank you. A strict comparison against false should do then. As a rule of thumb, it's better to check for what you want, than what you _don't_...

@JayJayArr and everyone who reviewed and contributed to the discussion: thank you for working on this! I look forward to seeing this in the next release. 💞

Some background: reason why this deprecation has not been handled yet, is that PHPCompatibility will only be able to detect it for a limited number of cases. To illustrate: *...

Same remarks apply as I left in my comment in #1980

@dd32 Thanks for the PR. I'm in two minds about this. The new text: > File operations are discouraged, and should use WP_Filesystem methods for Upgrade routines. Found: %s() ......