Jason Quense comments

Results 378 comments of


                                            Jason Quense

Flip Modifiers Not Applied

that change looks fine, i don't think you need to add any tests for it

Unable to run docs in dev mode in Windows

i wonder if maybe it's window specific issue. i'll try and debug a bit

Migration guide for replacing RootCloseWrapper?

Yeah, I don't think we want to support both API's. Esp since the component wrapper version if very simple to write. I'd suggest we put the example in the useRootClose...

Migration guide for replacing RootCloseWrapper?

@christianh25 read through the tests in the source here for examples. there is now `useRootWrapper` it is a hook version of the old component and basically functions the same way.

Use render prop instead of injecting props into children

I'm not sure the render prop gains anything here over using a component to control how props are passed through. ```js const MyTooltip = ({ style }) => ... ```

Use render prop instead of injecting props into children

>Otherwise there would be no way to pass the style prop. I'm not sure what you mean there, the style prop will be injected by Overlay.

Modal callbacks never being called

They are Transition callbacks, only called when a Transition component is provided.

Modal callbacks never being called

That'd be great :)

restoreFocus not working in Modal component in Firefox and Safari

please provide a reproduction, thanks!

Referenced component after one Portal?

I'm not sure there is anything we can do to fix this, without waiting a tick to get the container, which doesn't work for other reasons.