Jason Quense
Jason Quense
Hi, thanks for the PR. I'm not sure i understand what this adds or unlocks. You can already control the rendering of each as well as the portal `container`
thoughts folks?
interesting...the usages here in `useWaitForDOMRef` seem properly guarded unless i'm missing something: https://github.com/react-bootstrap/react-overlays/blob/24f7f518390f055c8832a4f61b9c2e62af511649/src/utils/useWaitForDOMRef.js#L5
This is intentional and inline with how native dialogs work. The focus _is limited_ to the modal but can cycle out of the window. You can tab from the url...
we really need to fix useRootClose
I don't think that's a good choice as a general behavior default, and not what native `dialog`'s do either. If you want to focus the first input when the modal...
huh does seem like the behavior has changed, maybe just fixed. I'm always open to making our components more accessible, we do have to balance the relative cost to gain,...
o yeah i'm sure the code exists for good reasons, and covers all the edge cases. I don't think that _we_ necessarily need to think about some of those edge...
which options aren't being passed?
Happy to take a PR fixing this if you want to send one over