Modal callbacks never being called

Open IceSentry opened this issue 8 years ago • 3 comments

I can't trigger any of the Modal callbacks

I copied the example in codesandbox and added onEntered, OnEntering and onShow and none of them got called back.

https://codesandbox.io/s/lryq54wowq

Mar 26 '18 21:03 IceSentry

They are Transition callbacks, only called when a Transition component is provided.

Mar 26 '18 21:03 jquense

Alright, thanks I'll try it tomorrow then. It wasn't super clear in the documentation. Could I make a PR to update the doc to make it a bit clearer that those callbacks require a transition component?

Mar 27 '18 02:03 IceSentry

That'd be great :)

Mar 27 '18 02:03 jquense