JP Simard
JP Simard
Doing that in #2299
I'll look into getting up to date numbers on iOS & Android for you, but in my last test for iOS in October, **Envoy Mobile added 5-6MB** to our App...
I just measured iOS again, and the numbers haven't changed since October. Envoy Mobile adds 5MB to the App Store decompressed app size.
@Bencodes can you try reviving this?
Still broken, filed https://github.com/CocoaPods/CocoaPods/issues/11372 to track a potential CocoaPods issue.
Thanks for the review, @goaway although the most important part of this to review is the Envoy side: https://github.com/envoyproxy/envoy/pull/20527
@benjamin-kramer When configuring rules, it needs to be done in a top-level yaml section: ```yaml opt_in_rules: - vertical_whitespace_closing_braces vertical_whitespace_closing_braces: only_enforce_before_trivial_lines: true ```
> Doesn't explain the lack of documentation though. Because the configuration description which is used to generate the docs is overridden to `N/A`: https://github.com/realm/SwiftLint/blob/60ad710b7f1ecb7edac8102cae0f2be6acf94f25/Source/SwiftLintFramework/Rules/Style/VerticalWhitespaceClosingBracesRule.swift#L60 I'll fix this shortly.
Fixing the docs in https://github.com/realm/SwiftLint/pull/4594