envoy-mobile icon indicating copy to clipboard operation
envoy-mobile copied to clipboard

Published 20 hours ago • verified publisher icon envoyproxy

iOS: Add `includeUnroutableDNSResults` to engine builder

Open jpsim opened this issue 3 years ago • 1 comments
trafficstars

If set, the resolver will avoid the system's heuristics to only return IPv4 or IPv6 addresses that it considers to be "routable", instead returning all possible IPv4 or IPv6 addresses.

This setting is ignored if the DNS lookup family is set to v4-only or v6-only.

This may be a useful setting to specify if the addresses considered unroutable by the system's heuristics may in practice be routable.

We may want to enable this in combination with happy eyeballs.

Description: iOS: Add includeUnroutableFamilies to engine builder Risk Level: Low, Apple-only, off by default Testing: I've confirmed both branches of the code paths are hit when the flag is on and off on a physical iPhone. I will validate the behavioral changes next before merging. Unit tests in progress... Docs Changes: In progress... Release Notes: In progress...

To Do:

  • [ ] Validate Behavior
  • [ ] Unit / Integration Tests
  • [ ] Docs
  • [ ] Release Notes

jpsim avatar Mar 25 '22 12:03 jpsim

Thanks for the review, @goaway although the most important part of this to review is the Envoy side: https://github.com/envoyproxy/envoy/pull/20527

jpsim avatar Mar 30 '22 13:03 jpsim

Closing as stale now that we've migrated to the Envoy repo: https://github.com/envoyproxy/envoy/blob/main/mobile/README.md

jpsim avatar Dec 01 '22 16:12 jpsim