envoy-mobile
envoy-mobile copied to clipboard
envoyproxy
Add a filter for applying Android socket tags
Add a filter for applying Android socket tags
Testing: Need help Docs Changes: Release Notes:
@alyssawilk can you take a look? I know I need tests, but hopefully I can lean on whatever testing gets set up for the cleartext check.
@Augustyniak If you have time, I'd appreciate your full review now that I think this is sorted out.
@Augustyniak If you have time, I'd appreciate your full review now that I think this is sorted out.
Sure. Sorry for a delays response - was OOO on Friday due to an org-wide recharge day.
I'm really confused by GitHub. I see an email from 2:04 PM Pacific today (2022-08-11) with a few comments that were sent after I uploaded a few new commits. But github says the commits were yesterday, and some of my comments are missing from the conversation view, or at least hidden. And some seem completely lost. I'm not sure what happened.
In any case, @Augustyniak I tried to explain that I updated the sample app to set socket tags, but end up with a java class not found error for the class org.chromium.net.AndroidNetworkLibrary which implements the tagSocket() method. I'm not quite sure how to resolve this. Any advice?
@RyanTheOptimist I modified the example app locally to enable socket tagging and run it to see whether I can repro the crashes that you mentioned locally. This is what I got:
That's despite your BUILD file changes in here https://github.com/envoyproxy/envoy-mobile/pull/2423/files#diff-bee4aeb6cd03b6684900f7c2d8bd51dec467011c33929eb3b34008a2a44deb23R19. This issue seems to be exactly the same issue as the one that's related is_cleartext_permitted and which was detailed in https://github.com/envoyproxy/envoy-mobile/issues/2432.
