Jeffrey Newman
Jeffrey Newman
I've added unit test that confirm that overflow protection on the NL model isn't changing any probabilities, it is just shifting the utility values into a range where exp(utility) doesn't...
I am adding settings to model components to allow users to turn overflow protection on or off by component. Per our discussions, there has been some debate about whether the...
My thinking here is that what causes the overflow & crash is only loosely connected to the underlying fundamentals of the model. Suppose your model is estimated based on observations...
Closed by #932
@dhensle you make a good point. Also, while I'm pushing fastmath through all the components, I realized its convenient to wrap all component level sharrow controls together (i.e., also `skip`)...
@dhensle this PR is ready for your re-review. I believe I addressed your concerns, and then some.
In thinking about the solution for #842, I realized we probably want these controls to be more general that "sharrow_settings", something more like "compute_settings". The reason we are seeing the...
@dhensle Will you have time to finish a (re)review of this PR this morning so we can merge it? It is now blocking progress on #833 as we want to...
I created a small placebo repository to replicate my problem: https://github.com/jpn--/placebo I can check out this repo, run "pre-commit install" on it to activate the hooks, then when I try...
I have installed pre-commit (and ruff, for manual use) via homebrew. I just updated homebrew itself, and both ruff and pre-commit to the latest versions, which has not fixed my...