James P. McGrath

Results 8 comments of James P. McGrath

I believe the history here is the `generate` method was introduced in the original release. If someone asks to generate a shortened url for an existing address, the logic was...

Hi there. This seems like a reasonable proposition. I would welcome a pull request (with appropriate specs) to migrate to a better maintained dependency.

You're right, it seems along the way we dropped this feature. AFAIK this was not a conscious decision to remove this, and I suspect it was an unintended side effect...

Coming in a bit late to the convo after reviewing @ThreadedStream's PR https://github.com/jpmcgrath/shortener/pull/144 It seems to me that this issue is that by converting to a string, you'd drop the...

Hi @Talha345 and @mchapman17. I cannot reproduce this issue, trying various combinations of Ruby (2.5.1, 2.7.6, 3.0.1) and Rails (5.2.8, 7.0.7), and following the instructions in the README. It is...

I have need of this feature as well. Is anything happening with it? Can I help in some way to move this forward?

Thanks @atuk84 @benlangfeld Amazingly quick respnse :-) I had just noticed that this didn't seem to be the active repo, thanks for the confirmation. I will check out the new...

I would also like to see something done here as well. Here's my suggestion: Add a form_html argument to the link_to and button_to helpers. Currently the button_to helper has a...