shortener icon indicating copy to clipboard operation
shortener copied to clipboard

Published 20 hours ago • verified publisher icon jpmcgrath

Use browser or crawler_detect gem instead of Voight-Kampff gem

Open v-kumar opened this issue 2 years ago • 2 comments

This gem uses https://github.com/biola/Voight-Kampff for bot detection. This gem has not been updated in 3 years and is not Ruby 3.0 incompatible. Several PRs and issues have been pending there unaddressed for a long time.

Use the more popular browser or [crawler_detect[(https://github.com/loadkpi/crawler_detect) for the same functionality.

We recently upgraded to ruby 3.0.3, and File.exists? deprecation warning from kampff gem are flooding the logs.

v-kumar avatar Apr 11 '22 01:04 v-kumar

Any comments @jpmcgrath ?

v-kumar avatar Apr 25 '22 21:04 v-kumar

Hi there. This seems like a reasonable proposition. I would welcome a pull request (with appropriate specs) to migrate to a better maintained dependency.

jpmcgrath avatar Apr 26 '22 11:04 jpmcgrath

@jpmcgrath I've made a PR to upgrade Voight-Kampff to a ruby 3 compatible version (2.0) https://github.com/jpmcgrath/shortener/pull/158

Blayr avatar Mar 15 '23 20:03 Blayr