James Allen

This seems related to https://github.com/immerjs/immer/issues/916, but the fix in https://github.com/immerjs/immer/pull/917 doesn't fix the case I've shown above.

Thanks for the reply! In the real situation where I've encountered this issue, I'm not setting another direct reference to `foo.bar.baz`, I'm actually setting the result of a `string.replace()`. I've...

Thanks for looking at this. This test is capturing the bug I described in https://github.com/immerjs/immer/issues/936, which has a bit more context as to what conditions triggered this error.

Another possibility might be to have events which bubble back up the chain, but introducing events for this might be overkill if only a single feature needs it.

The problem I'm having is that `AnnotationLayerBuilder` doesn't know about the top level `PdfListView`, which it needs to so that it can call a method like `PdfListView::navigateTo` when clicking on...

I would agree about the `ListView` being the correct place for it, except at the moment the `ListView` doesn't know about the `RenderController` and so cannot call `updateRenderList` when the...

Actually, ignore my last comment about `PdfListView` being redundant. It still does quite a bit of instantiating that it makes sense to keep separate.

LGTM (I've never fully groked the rendering code re canvas dimensions vs PDF.js dimensions, but this seems like an obvious improvement). The moving of lines 475-477 to 486-488 doesn't make...

We use the Ace editor (https://github.com/ajaxorg/ace) which is where the vim bindings come from. I suggest opening a ticket with them upstream for this since it's not something we support...

Ah, I see, this is more of a general tab behaviour settings issues rather than a Vim mode issue?