pdfListView icon indicating copy to clipboard operation
pdfListView copied to clipboard

Call this.resetRenderState() only once if dimension changed

Open jviereck opened this issue 11 years ago • 1 comments

@jpallen, can you do another small review here please?

Motivation for the change: If the viewport size changes, the this.resetRenderState(); should be called only once.

PS: @jpallen is that okay if I ask you for review on these PR? I don't want you to feel comitted to do the reviews and force you in doing anything but your help here is highly appreciated :)

jviereck avatar Sep 08 '14 09:09 jviereck

LGTM (I've never fully groked the rendering code re canvas dimensions vs PDF.js dimensions, but this seems like an obvious improvement). The moving of lines 475-477 to 486-488 doesn't make any difference?

jpallen avatar Sep 08 '14 09:09 jpallen