Jens Peters

Results 190 comments of Jens Peters

Thanks for the assessment, yeah, looks like a non-trivial feature to implement correctly. Unfortunately we don't use AsciiDoc internally, so I would prefer if this is added by someone who...

Thanks for the proposal. I've read it several times, but I don't think I fully understand what you are actually asking (it's already getting late here, that might not help...

This PR breaks the styling, thus it needs more attention.

> @jp7677 I've committed two small fixes which, as far as I can see, makes it so all colors are again as expected. Could you have a look? Thanks. we...

superseded by https://github.com/avisi-cloud/structurizr-site-generatr/pull/508

GTK also applies shadows to menus, may be that would also (additionally/alternatively) fit here.

> > What the 'fullscreen' option should do is a matter of preference. The idea from #1568 where 'fullscreen' ignores the tearing hint, is still valid and may be this...

> I think we should not have a `fullscreen` option at all then. But instead something like `fullscreenOnly` for this PR and potentially something like `enforceOnFullscreen` for the alternate case....

> > I think we should not have a `fullscreen` option at all then. But instead something like `fullscreenOnly` for this PR and potentially something like `enforceOnFullscreen` for the alternate...

PS: This is ready from my side. But ofc perfectly cool to wait until the release is tagged.