Jens Peters

Results 190 comments of Jens Peters

I'm running this PR now for daily use for a few days with no mouse attached and it works imho pretty good. A few minor quirks I have noticed: -...

> When two application windows are side by side, the left one is CSD/GTK4 and the right one is focused, I can grab the scrollbar of the GTK4 application but...

> What you describe sounds familiar, but I've not looked at patch, so might be barking up the wrong tree. > > When grabbing a scrollbar, you have to keep...

> When moving or resizing the Steam window, the cursor (sometimes) in Steam itself doesn't change shape anymore, e.g. no hand cursor above links. The UI still reacts to the...

> So only the GTK4 scrollbar quirk is left (based on my own testing). I found a way to work around this issue, by doing additionally `wlr_seat_pointer_notify_motion(tool->seat->seat, time, 0, 0)`...

> I'm only half way through the commit in terms of review. Thanks a lot for already looking into the details! > Comments so far: I've addressed the renames in...

> Makes sense now. There is already a fairly length comment, but suggest adding some/all of the above for future devs 😄 Thanks and done!

I think this should be good now. Please let me know if i should open a separate PR for the first commit. I guess I'll take a look at the...

> This looks good to me as well. Didn't detect any issue while testing and overall feels very complete. With the comment added as raised by malm I'd say lets...

This scenario is indeed currently not supported, see https://github.com/avisi-cloud/structurizr-site-generatr/blob/main/src/main/kotlin/nl/avisi/structurizr/site/generatr/site/model/ToHtml.kt#L84 Since you are familiar with the topic and setup for this, any chance your could create a PR for this?