Jens Peters
Jens Peters
@ahesford Thanks for the review. I've rebased this PR and addressed your points and the toggle works now even better, thanks! @Ph42oN Would be nice if you could still take...
> Also, I'm ambivalent about the `fullscreenForced` value. Another possibility would be splitting another core Boolean option, _e.g._, `forceTearing`, that could apply when `allowTearing` is either `yes` or `fullscreen`. (When...
(last forced-push was just a styling nit, removed not needed `else` at the end of the function)
> I'll also need to modify `tiled_not_maximized` in `ssd_update_geometry()`, but I don't get why `view_is_tiled()` is used here rather than `view_is_tiled_and_notify_tiled()`. @jp7677 any ideas? > > https://github.com/labwc/labwc/blob/72f59c32a2d2ee33bf74452cea39c821ce60fbb2/src/ssd/ssd.c#L252 From my memory:...
> So I guess this inconsistency is just a small mistake (and I think this is not causing any bugs). But I wanted to make sure this is not intentional...
Does https://github.com/labwc/labwc/pull/1883 makes a difference?
I guess indeed a good idea to take a look at Sway and also at Gnome (on Wayland). From a brief glimpse, looks like xournal++ is a GTK3 application. Do...
thx. Could you please do the same with `gtk4-demo`?
I would advice to open an issue at `wlroots` about this (https://gitlab.freedesktop.org/wlroots/wlroots/-/issues). If I had to make a guess (but really not sure), then I think this has to do...
> Maybe you mean `` which prevents unintentionally closing menu? That is also the one I remember where initially the implementation didn’t worked for tablet pens.