Joy Wang

Results 50 comments of Joy Wang

> Can we also update > > https://github.com/MystenLabs/sui/blob/21c26ce6a5d4e3448abd74323e3164286d3deba6/sdk/typescript/src/types/common.ts#L23 > > ? thanks for catching, added and fixed unit tests. there is no e2e search test for tx digest thats why...

> Thanks for pinging me @kchalkias! Is the change only for tx digest (and not object digest)? If so, then we’re good. If it affects object digest then we’ll need...

@666lcz im not an expert on React, but from what i see, this `TransactionResult()` is called exactly once when the url for /transaction/:id is loaded and all TxState are loaded...

another idea is we can make "aggregated signature" a clickable redirects that loads its auth signatures.

discussed with @Jordan-Mysten offline, we would use 2) to make a separate RPC call to load auth signers, this PR just adds the endpoint, @Jordan-Mysten will work on the pure...

@jonas-lj @kchalkias PTAL - this requires ecrecover and verify for both k1/r1 to take in a hash_function u8 param. and require the msg to be a raw msg.

> > This is to make sure internals of the signature is not leaked in deserialized form. They are all represented by most compact bytes form. > > Tested against...

sorry for the delay on this - PR is ready for review

will rebase and open a new PR