Joy Wang
Joy Wang
closing for now
will open a new diff since things had changed quite a bit since last PR
https://github.com/MystenLabs/sui/pull/6644 first three completed via
- User transaction intent signing [PR 1](https://github.com/MystenLabs/sui/pull/6445), [PR 2](https://github.com/MystenLabs/sui/pull/8321) - Authority intent signing [PR 1](https://github.com/MystenLabs/sui/pull/8154), [PR 2](https://github.com/MystenLabs/sui/pull/8726)
> Would it be possible to take this as an occasion to make fastcrypto a workspace dependency? this is already done! https://github.com/MystenLabs/sui/pull/5115/files
can we add `#[derive(Debug, Serialize, Deserialize)]` to struct Proof and TransactionProof ? useful for external caller.
are you trying to use rust sdk as wasm from browser? if so you should just use the typescript sdk. zklogin works with openID which is essentially a oauth flow...
the address derivation from enoki and ts-sdk and rust implementation are always identical (otherwise, no zklogin transaction can ever happen on sui network) since every txn assembled by any sdk...
in general i prefer this to live outside the main sui cli. ssh keys are encrypted for a reason, if i import an encrypted ssh key to sui cli it...
this is not a bad change, although the function is not used anywhere other than tests. if you are relying on this function, consider use `SuiKeyPair::from_bytes`