sui icon indicating copy to clipboard operation
sui copied to clipboard

chore: Audit messages.rs

Open joyqvq opened this issue 2 years ago • 2 comments

Description

Optimize Vec with reference, clean up unused/dup methods, remove unwrap as much as possible

Test Plan

How did you test the new or updated feature?


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • [ ] user-visible impact
  • [ ] breaking change for a client SDKs
  • [ ] breaking change for FNs (FN binary must upgrade)
  • [ ] breaking change for validators or node operators (must upgrade binaries)
  • [ ] breaking change for on-chain data layout
  • [ ] necessitate either a data wipe or data migration

Release notes

joyqvq avatar Apr 03 '23 22:04 joyqvq

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Apr 27, 2023 9:16pm
explorer-storybook ⬜️ Ignored (Inspect) Apr 27, 2023 9:16pm
sui-wallet-kit ⬜️ Ignored (Inspect) Apr 27, 2023 9:16pm
wallet-adapter ⬜️ Ignored (Inspect) Apr 27, 2023 9:16pm

vercel[bot] avatar Apr 03 '23 22:04 vercel[bot]

sorry for the delay on this - PR is ready for review

joyqvq avatar Apr 27 '23 21:04 joyqvq

will rebase and open a new PR

joyqvq avatar May 08 '23 19:05 joyqvq