Joshua Hannan

Results 201 comments of Joshua Hannan

I'm actually going to hold off on including the scoped provider for now. It is something we will definitely include in this upgrade the future, but I don't want that...

@justjoolz I don't understand the use case very well, so I'm not totally sure, I don't think it could create new token types at run time that are equivalent to...

@bjartek Yes, we're also going to refactor the tests here to use a better testing framework, but just haven't gotten to it yet

I still don't really see the need to deploy a whole new contract to do this, even with the existing fungible token standard. They could just give their vaults an...

@justjoolz maybe I am misunderstanding what you mean by "compliant," but it seems pretty straightforward. You just add an identifier field to the vault and change the minting and vault...

That is an interesting suggestion, @lukaracki. They're in the standard as a security measure to make sure the core vault resource has a strictly defined behavior. If you want to...

@alilloig I already pitched this idea in [the NFT standard PR](https://github.com/onflow/flow-nft/pull/126#issuecomment-1259914182), so lets keep discussion over there for now since it is the same as it is here

Can you put the `test` directory into a `lib/js/` directory so it isn't at the top level? Thank you!

Also, it looks like you haven't pulled the latest changes from `master` to merge [these changes](https://github.com/onflow/flow-ft/pull/68) into your branch. Can you do a `git pull` and push your branch also...

@bluesign I like your idea to use `Path` to add the vault and initialize the switchboard. I think it would be good to include that. `createSwitchBoardFromPaths( [PublicPath] ): @SwitchBoard` would...