Joshua Hannan

Results 222 comments of Joshua Hannan

I think it makes sense to update the `ExampleNFT` contract to not add those path fields in the `Collection`. It also makes sense that it would complain about the mismatching...

I'm still leaning towards requiring it. I don't have an issue with a little more verbosity, and the issue about upstream updates updating and breaking downstream code doesn't seem like...

@bjartek correct me if I am wrong, but I think that is a separate issue. I think this issue is just about the conformance list, not the default implementations

I see the issue now. yeah, if possible, it seems like we could say that since `Vault` inherits from `Receiver`, then we can just use the default implementation from `Vault`....

Is this something that we think could be possible? We'd like the NFTStorefront and USDC contracts to be deployed to the emulator for bootstrapping, but can't do it without this

If I understand correctly, we are uncomfortable updating the flow-go bootstrapping, but shouldn't there be code in the emulator repo somewhere that we can add more bootstrapping code to and...

@janezpodhostnik Would you be able to take a look at my previous comment? It would help unblock me from figuring out how we want to do the emulator bootstrapping for...

I'd really like to help with this but I'm not sure where to start. Like I said before, we also need to update emulator bootstrapping for the bridge, so I...

In [this PR, ](https://github.com/onflow/flow-core-contracts/pull/379), I moved the rewards calculation to the beginning of the epoch commit phase so that it freed up some computation at the end of the epoch,...

Good suggestion! I updated the title and description of the issue to reflect that. We can just deploy it to the service account and store the minter there like we...