Joshua Hannan
Joshua Hannan
This looks like it would be super useful! It has always been annoying to have to go back and forth between the docs and playground to test stuff out so...
@Aliserag has been on vacation I believe, so it has been a little slow getting grants through. Sorry about the delay! I'm still supportive of it! We'll try to get...
I'm definitely in support of this. It would be super useful for me and many others in the ecosystem!
I just want to make sure this will also be able to estimate gas usage because that really is the metric that most developers care about because they need to...
So this would be a view that you'd want to include in the MetadataViews contract, or somewhere else? And it isn't something that an NFT or NFT collection exposes, right?...
okay, I understand this a little better now. I like Bjarte's proposal, agree with calling them maker and taker, and I don't think we need to include royalties or cuts...
yeah I think this view is totally necessary, but I'm just wondering if we want to approve something right away or give it some time.
@sisyphusSmiling I addressed your comments about the contracts and pushed my changes. I created [an issue](https://github.com/onflow/nft-storefront/issues/95) for the transaction changes that I am going to come back to later
@sisyphusSmiling I got the Cadence tests passing here and re-staged the contract on testnet so it would hopefully pass the next migration. I need help with all the JS stuff,...
@sisyphusSmiling I addressed your comments and resolved the conflicts. Thanks for updating the JS stuff! There is no rush on getting them passing though. You can come back to it...