Josh Moore

Results 1000 comments of Josh Moore

Things are green and reading https://docs.python.org/3/library/pickle.html#object.__reduce__ this seems to follow sensibly, but open to other opinions. @d-v-b: can you coordinate the entries you want for docs/release.rst for this?

If we were to use jupyterbook, https://jupyterbook.org/interactive/comments/utterances.html would be an option! :smile:

Thanks again for the notebook, @sudoyolo. I think we're all still excited about the idea of embedding a notebook in the docs. If you (or anyone else finds time) for...

Glad to hear it, @GbotemiB. For learning more about jupyter book, you might take a look at the original blog post: https://blog.readthedocs.com/jupyter-book-read-the-docs/

Hi @ShristiJain. I think based on the age that this is going to be a case of there being a solution in place. For example, see the visit functions here:...

Knowing little about the requirements here, just looking at the example: ``` zarr.array(a, chunks=10, meta_array=cupy.empty(()), compressor=CuPyCPUCompressor(Zlib())) ``` I wonder a couple of things: - Could this be done higher-level? As...

Rebased and fixed the conflicts. Currently seeing a number of these: ``` if not hasattr(value, 'shape'): [5734](https://github.com/zarr-developers/zarr-python/runs/5106294836?check_suite_focus=true#step:7:5734) > value = np.asanyarray(value, like=self._meta_array) [5735](https://github.com/zarr-developers/zarr-python/runs/5106294836?check_suite_focus=true#step:7:5735) E TypeError: asanyarray() got an unexpected keyword...

Ah, ok. There's a job that pins to 1.17 for testing the minimal version.

@madsbk: I'm slowly working my way towards a re-review here, but in the meantime, any thoughts on the codecov front?