Josh Moore

Results 939 comments of Josh Moore
trafficstars

@aliaksei-chareshneu : no chunks (i.e. no data) should be loaded at this point. Only _metadata_ about how chunks there are, where they are located, etc.

Build showing various errors (though not the specific one from #844): ``` FAILED zarr/tests/test_core.py::TestArrayWithN5FSStore::test_nchunks_initialized FAILED zarr/tests/test_core.py::TestArrayWithCustomMapping::test_nbytes_stored FAILED zarr/tests/test_core.py::TestArrayWithFSStorePartialRead::test_append_2d FAILED zarr/tests/test_core.py::TestArrayWithFSStorePartialRead::test_append_2d_axis FAILED zarr/tests/test_core.py::TestArrayWithFSStorePartialRead::test_array_1d FAILED zarr/tests/test_core.py::TestArrayWithFSStorePartialRead::test_array_1d_fill_value FAILED zarr/tests/test_core.py::TestArrayWithFSStorePartialRead::test_array_1d_selections FAILED zarr/tests/test_core.py::TestArrayWithFSStorePartialRead::test_array_2d FAILED zarr/tests/test_core.py::TestArrayWithFSStorePartialRead::test_array_2d_edge_case...

Updated the branch today. Another phenotype in case it gives anyone any clues: ``` =================================== FAILURES =================================== ________________ TestArrayWithCustomMapping.test_nbytes_stored _________________ self = def test_nbytes_stored(self): z = self.create_array(shape=1000, chunks=100) assert 245...

Hey @avalentino. No, no new news since I assumed I was doing something wrong with this PR. Very much thanks for the heads up that this is in the wild!

Re-enabled GHA after https://github.com/zarr-developers/community/issues/44 but now need to fix: ``` E: The repository 'http://ports.ubuntu.com/ubuntu-ports hirsute-security Release' does not have a Release file. ``` https://fridge.ubuntu.com/2022/01/21/ubuntu-21-04-hirsute-hippo-end-of-life-reached-on-january-20-2022/ Moving to focal (20.04LTS).

@jakirkham: that would work inside of the docker?

Going to re-open to try to get travis green. Coveralls will stay red until a test is added.

Hi @willirath, I've updated this branch and all existing tests are passing. Are you still interested in taking it forward?

Thanks for the ping, @willirath, definitely time. I personally don't foresee too much review capacity during the holidays, but will leave the tab open. Obviously, if anyone else could jump...

Ah, nice. With a clearer 2022 head, I notice just how complementary this is to @d-v-b's #753 and @jni's #853. In Zarr 2.11, the default will become to not serialize...