Josh Dick

Results 35 comments of Josh Dick

I'd love to see this become part of `nvm`! 👍 @edwmurph I wonder if you could limit the network requests even further (once per day or even per configurable time...

FWIW, I added the onedark airline theme into vim-airline-themes (in turn based on the one that ships with my own joshdick/onedark.vim) [back in 2017](https://github.com/vim-airline/vim-airline-themes/commits/master/autoload/airline/themes/onedark.vim), but I haven’t kept changes between...

@andreypopp Worked the ideas from [your gist](https://gist.github.com/andreypopp/482c78a992acd3de70793bde62584392) into a hybrid; I'm curious for your thoughts!

Have you had this issue with any other colorschemes? onedark.vim has no special interaction with airline aside from setting global variables for its theme colors (nothing conditional based on file...

The [lines in the `nvim-treesitter` source you linked](https://github.com/nvim-treesitter/nvim-treesitter/blob/a74da044a8c208177c0af56eeab709859e2fda38/plugin/nvim-treesitter.vim#L30-L84) do `highlight default link`s back to default/fallback highlight groups that are already styled by onedark.vim. I haven't gotten around to trying `nvim-treesitter`...

The equivalent of this change was included in #271. Let me know if that resolves this issue.

Thanks for your proposal! I basically threw your suggestion verbatim into https://github.com/joshdick/onedark.vim/pull/229. A A quick manual test seems to be working as intended to me, but can you verify that...

I also don't understand the intention behind `dartCoreClasses` since it seemingly doesn't appear in https://github.com/dart-lang/dart-vim-plugin; can you clarify how the gist you linked is related?

@l0nax All colors currently used by the theme are located here: https://github.com/joshdick/onedark.vim/blob/master/build/build.js#L8 The build system substitutes them into the theme thusly: https://github.com/joshdick/onedark.vim/blob/master/autoload/onedark.vim#L5

> Yes, but do you have a scheme like "operators are colored red", ... Those types of relationships are defined in `colors/onedark.vim` starting here: https://github.com/joshdick/onedark.vim/blob/master/colors/onedark.vim#L169 > The `dartCoreClasses` is an...