onedark.nvim icon indicating copy to clipboard operation
onedark.nvim copied to clipboard

Provide a theme for vim-airline?

Open moshiur-raj opened this issue 4 years ago • 12 comments

onedark.nvim does not provide any theme for vim-airline. Switching to this theme makes airline stick to the default themes and it looks ugly.

moshiur-raj avatar Jul 05 '21 06:07 moshiur-raj

Sure. I will add it.

navarasu avatar Jul 05 '21 07:07 navarasu

Thank you.

moshiur-raj avatar Jul 05 '21 07:07 moshiur-raj

@moshiur-raj Instead of vim-airline. I thought to support lua only status plugins like hardline, bufferline. Your Thoughts?

navarasu avatar Jul 22 '21 10:07 navarasu

@navarasu Sounds reasonable to me. I actually was able to fix the problem with airline. airline provides extra themes with vim-airline-themes. So you don't need to maintain it. I recently switched to lualine.

moshiur-raj avatar Jul 22 '21 11:07 moshiur-raj

@moshiur-raj Instead of vim-airline. I thought to support lua only status plugins like hardline, bufferline. Your Thoughts?

@navarasu perhaps also that, but don't refrain from supporting vim-airlaine. Vim-airline is a widely used plugin, and offers functionality that goes beyond the chosen colorscheme. Many of us have lots of plugins already configured for airline, and having to redo that work for that plugin, just only for the theme, doesn't worth it.

baco avatar Aug 07 '21 15:08 baco

@baco vim-airline already provides a onedark theme. It's available here.

moshiur-raj avatar Aug 07 '21 15:08 moshiur-raj

@moshiur-raj fair enough. Never installed it, because @joshdick's onedark.vim came with it's own implementation for Airline

baco avatar Aug 07 '21 22:08 baco

FWIW, I added the onedark airline theme into vim-airline-themes (in turn based on the one that ships with my own joshdick/onedark.vim) back in 2017, but I haven’t kept changes between those two versions synced.

joshdick avatar Aug 07 '21 23:08 joshdick

FWIW, I added the onedark airline theme into vim-airline-themes back in 2017, but I haven’t kept changes between those two versions synced.

Will you PR an update there, please?

baco avatar Aug 08 '21 06:08 baco

@baco As I support 5 more color variants, adding a theme to vim-airline-themes will not be good. So I will add airline support in this plugin itself by supporting all color variants. I think it is fine to support few vim plugins until the Lua plugins get mature.

navarasu avatar Aug 08 '21 13:08 navarasu

Thak you @navarasu, that's excellent news!

baco avatar Aug 08 '21 15:08 baco

Any further update on this? @navarasu

schardev avatar Feb 21 '22 19:02 schardev