Josh Abernathy comments

Results 79 comments of


                                            Josh Abernathy

is Hot Reload support for react app?

Hi @Mahdi-Hazrati, yes it is, it should work out of the box.

Base application and UI infra

Thanks for the PR, but we'd prefer to keep the template very simple so that it's easy for folks to get started with.

Changes tab should respect showUntrackedFiles

It seems reasonable to me that we'd let the config value take precedence on this 👍

diff shows "file is empty" when file metadata has changed

I'd guess this is a file mode change?

Investigate whether we can short-circuit fetch

It'd also mean we'd only have to lock refs when we know something actually changed, relevant to https://github.com/desktop/desktop/issues/1128.

Window needs a border if shadows are turned off

>is there a macOS equivalent where you can disable window shadows like this @joshaber? LOL no that's crazy talk.

self-signed certificates - polish the flow

>support stacking dialogs so that we can push and pop dialogs within the app @desktop/design if we all agree that this is desirable from a UX point of view, I...

Random "Is the docker daemon running?" with Docker-in-Docker Feature

We've had internal reports of this as well with Debian 11.

Exact Types

This is probably the last thing I miss from Flow, compared to TypeScript. The `Object.assign` example is especially good. I understand why TypeScript behaves the way it does today, but...