Josh Abernathy
Josh Abernathy
Really odd, it looks like it can't determine the application ID. Anything odd about your computer setup or where you have VS Code installed?
@coreybutler That sounds like https://github.com/Squirrel/Squirrel.Mac/issues/131 which was fixed in https://github.com/Squirrel/Squirrel.Mac/pull/207.
Yes, it’s in Electron though I’m not sure which versions include the fix.
It looks like the fix was released in Electron 1.7.9: https://github.com/electron/electron/releases/tag/v1.7.9
@etyp I downloaded the version tagged Electron 1.7.9 and verified it has the proper ShipIt version. I'm not sure if there could be caching at play.
It'd certainly be great! Pull requests welcome :smile:
@psequel Can you explain how to reproduce this? It'd be pretty surprising and looking at the code I'm not sure why that'd happen.
Yes, the code signatures of both builds must match for Squirrel to perform the update.
> But if you take a look at my logs, the second time [...] Oh, I didn't notice that! I'm not sure how to explain that without digging into it...
I'd argue basically every app would want this behavior. Worst case, GHfM can manually check again after loading user info.