Josh

Results 20 comments of Josh

> So I just have a little helper fn I use to get what I want. Are you keeping track of the interceptors separately? I don't think there is a...

Note the types don't seem to match v7. Is the API mostly finalised for v7? I could try creating up to date types when I have time.

Not sure what I am doing wrong but when I use ^ config on a new CRA project I get different hashes for my style / class name. If I...

Just reprod it doing 1. `npx create-react-app my-app` 2. `cd my-app` 3. `npm install @craco/craco babel-plugin-react-css-modules` 4. Rename `App.css` to `App.module.css` 5. Rename `className` to `styleName` in `App.js` 6. `npm...

Seems like the issue is a difference in the content property that gets passed to `loader-utils` **css-loader** ``` src\\App.module.css+App ``` **babel-plugin-react-css-modules (via `generic-names`)** ``` src/App.module.css+App ``` Also, I'm wondering if...

For some reason CRA uses `css-loader` v1, I'm thinking of updating it to v2 as it might do things the same way as `generic-names`. If that doesn't work I'll create...

Can confirm it works with `css-loader` v2 so maybe we just need to document that somewhere. Still not sure why CRA uses `css-loader` v1.

Looks like the `css-loader` dependency will be updated to v2 in CRA v3: https://github.com/facebook/create-react-app/pull/6614 Not sure how no one else has come across this when using CRA and `babel-plugin-react-css-modules`.

Is he no longer at Shopify? Or no longer interested in this project?