Michael Joseph

Results 21 comments of Michael Joseph

I think this feature would be really useful as well! Jupyter Book has a nice [implementation](https://jupyterbook.org/interactive/hiding.html#toggle-admonition-content-with-dropdowns) where the title of the dropdown can also be customized. I think it would...

It seems like there are 2 places where the bvals are getting rescaled: [1](https://github.com/nipreps/dmriprep/blob/26a64f049d1a4b34557e1bfc3a8267a111ab724d/dmriprep/utils/vectors.py#L359) and [2](https://github.com/nipreps/dmriprep/blob/26a64f049d1a4b34557e1bfc3a8267a111ab724d/dmriprep/utils/vectors.py#L366) I was looking at how MRtrix3 handles this and they scale by the [squared...

I ran into this issue again when working with the NTU-DSI-122 dataset. The `round_bvals` function artificially introduces b0s into the dataset. Below is what MRtrix3 outputs vs DiffusionGradientTable: MRtrix3 ```...

I'll update this to see if I can figure out a parser that determines whether the data is shelled or sampled along the Cartesian grid. I've checked out the methods...

This is ready for review. I will leave the DSI updates for another PR.

@oesteban tests are failing after some of the changes to the dwi reference workflow. will wait until #153 gets merged and then will rebase

Added a bunch of mostly nitpicking comments and made some suggestions to help shorten the line lengths for your docstrings.

> @josephmje -- I went ahead on the latest commit and modified the out_path behavior, but now I see that you have been tackling this in #81 . Would you...

**Denoising** - MP-PCA: implemented in [dipy](https://dipy.org/documentation/1.4.1./examples_built/denoise_mppca/), [MRtrix](https://mrtrix.readthedocs.io/en/latest/reference/commands/dwidenoise.html#dwidenoise) and [DESIGNER](https://github.com/NYU-DiffusionMRI/DESIGNER/blob/master/utils/mpdenoise.py) - MP-PCA non-local patch: - Patch2Self: implemented in [dipy](https://dipy.org/documentation/1.4.1./examples_built/denoise_patch2self/#example-denoise-patch2self) - using [NORDIC](https://www.biorxiv.org/content/10.1101/2020.08.25.267062v1.full) in combination with Patch2Self? **Unringing** - subvoxel shifts -...

@oesteban sorry for the late reply on this. i'd be happy to share some data. do you have a preferred method for receiving them?