Joscha Feth
Joscha Feth
> or is there a situation where this would be essential? Generally I suppose I could always transform from a Date into an ISO string. I did notice that currently...
friendly ping @dsherret :)
> is there a config or something I need to toggle? I think this is coming from https://github.com/denoland/wasmbuild via https://github.com/denoland/dnt/blob/00b9ab70716668ab781d0d99141e52a19e15e756/mod.ts#L350 but I am not 100% sure. I tried to find...
Example here: https://gist.github.com/joscha/49e26fb6a2e3b9cbae0f1f44b5879ec6 Run: ``` deno run -A build.ts 0.1.0 cat npm/src/foo.ts ```
Just ran into this via `bl`: ``` > node test_runner.js Running tests in ./esm/node_modules/.deno/[email protected]/node_modules/bl/test/test.js... node:internal/modules/cjs/loader:1143 const err = new Error(message); ^ Error: Cannot find module 'tape' Require stack: - /Users/joscha/dev/a-node/npm/esm/node_modules/.deno/[email protected]/node_modules/bl/test/test.js...
@mtth can't we just add `| Type` to `DefinedType` for this?
> > @mtth can't we just add | Type to DefinedType for this? > > Seems like it. We should also then simplify `AvroSchema` to omit `Type`. I'll open a...
> > @mtth can't we just add | Type to DefinedType for this? > > Seems like it. We should also then simplify `AvroSchema` to omit `Type`. https://github.com/mtth/avsc/pull/476
> I think it makes sense to switch to TypeScript eventually. okay. Given #452 was just merged, this could be a great time?
I believe this would also solve the issue described here: https://dlthub-community.slack.com/archives/C04DQA7JJN6/p1732199697666119 Background: I have a data source that has this data in rows: ```json { "id": 1, "links": [ {...