Midnight Commander Linux file highlight.

[stovesy]

v1.0.211 When selecting files with the insert key on Midnight Commander, the file highlight count increases, so the files are being selected, but the selected files are not highlighted (usueally yellow fg)

run mc from bash on linux

Thank you.

[vercel[bot]]

@joscha is attempting to deploy a commit to the Pipedreamers Team on Vercel.

A member of the Team first needs to authorize it.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
pipedream-docs-redirect-do-not-edit	⬜️ Ignored (Inspect)			Aug 22, 2024 5:20pm

[coderabbitai[bot]]

Walkthrough

The recent modifications to the JSONValue type definition enhance its versatility by including Date as a valid type. This allows for a broader range of data representations, accommodating date objects alongside existing types like numbers, booleans, null, arrays, and objects. As a result, developers can work with more complex data structures that involve date representations, improving the flexibility of data handling in the application.

Changes

File	Change Summary
types/src/index.ts	Updated JSONValue type to include Date, expanding its capabilities to represent more data types.

Poem

In a world of JSON, oh so bright,
A Date hops in, a joyful sight!
With numbers, booleans, it takes its place,
Expanding the types, a lovely embrace.
Data dances, structures grow,
Thanks to this change, we're ready to flow! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vunguyenhung]

Hey @joscha @luancazarine @GTFalcao, may I ask how can I test this?

[joscha]

Hey @joscha @luancazarine @GTFalcao, may I ask how can I test this?

If we create a new object in the types tests that looks like this:

const x: JSONValue = {
  myDate: new Date()
}

It should pass the type check. Do you have runtime tests for this part as well? Somewhere inside your closed source? Then you could add the same structure in the unit test where your serializer is tested.

[joscha]

I've verified all other types where JSONValue is used, and I don't see any negative impact that could be caused by the addition of Date.

Great! Should I add some rudimentary tests for this?

Note: this needs a version increase before it can be merged and published.

Is that something the releaser does or do you want me to bump the version in this pull request?

[GTFalcao]

@joscha the version increase should be part of the pull request, yes.

Can you provide some more context on the usefulness of being able to export/return a Date object directly, instead of converting it to a ISO string first? Is that just for the shortcut, or is there a situation where this would be essential?

The reason I ask is, since Date is not a universally serializable JSON value (like a string or number), it may not make sense to be added as a JSONValue.

[joscha]

or is there a situation where this would be essential?

Generally I suppose I could always transform from a Date into an ISO string. I did notice that currently Pipedream does serialize the Date type, but the type definitions suggest it doesn't, so this PR is mainly bringing the type definitions up to par with what the Pipedream implementation actually does. An alternative would be to throw an error in the serialization logic of Pipedream (when using $.export or return), however that would be a backwards-incompatible change, thus I assumed it would make more sense to update the types.

[malexanderlim]

Hi @joscha, thanks for identifying this behavior with Date objects in our system. I'm going to close this PR for now, as we would like to keep our options open for a more robust date/time implementation in the future. Keeping the types more conservative now will give us more flexibility for a proper native date handling in the future.

Thanks for your contribution and we'd be happy to revisit this down the line.