Joscha Feth
Joscha Feth
#24397 is closed against `1.45.0` which means in `1.45.2` (see above) it shouldn't panic anymore?
> Are there other similar libraries that share this? I haven't come across one https://github.com/facebook/jest does this as well, first run will create the baseline. Given we hopefully all use...
Short reference to https://gist.github.com/joscha/d8603a1f0af5b0b055546c792b2a8ff6, which can be updated once this pull request lands.
are you sure this is a valid fix? now the code is always run when `!supports_onhashchange` is `true` whereas before it was only run when executed in IE.
Its only checking for IE that is missing, right, so how about changing that code to: ``` javascript (navigator.userAgent.match(/MSIE/i) !== null) ``` ?
I sent a pull onto your fork, if you want to add that to this pull.
We have a step that is changing infrastructure - it has a rollback/cleanup mechanism at the end if something went wrong. This rollback is never executed if the job gets...
Just discovered this: Almost 100% certain this just appeared for us...anyway, thanks BK :)
Only improvement which would make this even better is a link to the blocking builds :)
references https://github.com/buildkite/feedback/issues/374