Johannes Röder

Results 88 comments of Johannes Röder

hey, thanks for your feedback! > To be honest, I would just use an additional sink… Is there some reason against this solution? Yes, this could be a good option...

Hey, thanks for the discussion so far - maybe there is need for opening a separate issue for that discussion? But back the HeatPipeline component. Uwe came up with the...

> Question is how to handle situations in which the flow is zero. Either one makes sure that this never happens, or an integer variable encodes if the network is...

> (1) Shows a heat pipeline that can be turned off. This implies an integer variable. A way to implement this would be using the existing OffsetTransformer. (2) shows the...

> ``` > get_operation_range(diameter, length, temp_inlet, temp_return, isolation, roughness, mass_flow_max) > > ... I like your suggestions. This precalculations are necessary in any of the implementations . The most difficulat...

There are few good examples: [OffsetTransformerBlock](https://oemof.readthedocs.io/en/stable/api/oemof.solph.html#oemof.solph.components.OffsetTransformerBlock) [ExtractionTurbnineCHPBlock](https://oemof.readthedocs.io/en/stable/_modules/oemof/solph/components.html#ExtractionTurbineCHPBlock) [GenericCHPBlock](https://oemof.readthedocs.io/en/stable/_modules/oemof/solph/components.html#GenericCHPBlock) [GenericStorageBlock](https://oemof.readthedocs.io/en/stable/_modules/oemof/solph/components.html#GenericStorageBlock) ->maybe there needs to be still some small adaptions There has not been written a template yet. This was the aim...

Hey, are you okay with the new appearance of the docstring, which is now shown in the InvestmenFlow? Are there any errors? What is missing? Any further ideas for improvement?...

I just noticed that in the "template-docstrings" of ExtractionTurbnineCHPBlock and GenericCHPBlock, the section, which describes the variables, which are defined in the component (*The following variables are created:*) is missing....

#636 gives an example of how the symbols could be in the parameter docstring: [oemof.solph.options.Investment](https://oemof.readthedocs.io/en/features-add_nonconvexinvestmentflow/api/oemof.solph.html#oemof.solph.options.Investment) [oemof.solph.blocks.InvestmentFlow](https://oemof.readthedocs.io/en/features-add_nonconvexinvestmentflow/api/oemof.solph.html#oemof.solph.blocks.InvestmentFlow)

https://github.com/oemof/oemof/pull/636#pullrequestreview-373458735 @oemof/documentation What do you think about that?