Jorge Manrubia

Thanks so much for taking this to the finish line @engwan. I'll review this before the week ends and we'll merge 🙏.

This workaround worked: ```ruby module Datadog::Tracing::Contrib::Rails::Framework def self.activate_active_job!(datadog_config, rails_config) end end ``` And then this worked: ```ruby config.tracing.instrument :active_job, service_name: "active_job" ```

Thanks for the clarifications on the names rationale @delner, I think that helps, and changes a bit the mental model I had 👍. I think a little problem right now...

Sounds perfect @delner. Thanks!

I managed to get the `configured` label to appear for action cable with: ```ruby config.tracing.sampler = Datadog::Tracing::Sampling::PrioritySampler.new( post_sampler: Datadog::Tracing::Sampling::RuleSampler.new( [ Datadog::Tracing::Sampling::SimpleRule.new(service: "action_cable", sample_rate: 0.1), Datadog::Tracing::Sampling::SimpleRule.new(service: /^redis.*/, sample_rate: 0.1) ] )...

Another example where sampling is not working. We have a custom service where we trace spans like this: ```ruby Datadog::Tracing.trace "image_preview.generate" do |span, trace| span.service = "bc3-image-previews" ``` In the...

@marcotc thanks for the tip, unfortunately changing that didn't make a difference. I changed it to: ```ruby Datadog::Tracing.trace "image_preview.generate", service: "bc3-image-previews" do |span, trace| ```

It doesn't work for sampling `mysql2` either: ```ruby config.tracing.sampler = Datadog::Tracing::Sampling::PrioritySampler.new( post_sampler: Datadog::Tracing::Sampling::RuleSampler.new( [ Datadog::Tracing::Sampling::SimpleRule.new(service: "bc3-image-previews", sample_rate: 0.1), Datadog::Tracing::Sampling::SimpleRule.new(service: "mysql2", sample_rate: 0.5) ] ) ) ``` For us, sampling not...

@delner 👍 I’ll prepare something I can share here.

I found something interesting when trying to come up with a minimal setup to share: what causes the leak is to enable profiling. So I can reproduce with this setup:...