Jorge Manrubia
Jorge Manrubia
@delner > Can you explain a bit more why you'd like to sample down these services? (Databases, caches?) Are they noisy? Yes. More than noisy, they are very expensive to...
> It doesn't seem like single span sampling addresses this in my initial testing, as it seems to be designed for hoisting spans that would have been dropped "up" to...
@marcotc thanks for your suggestion. I tried this for trying to get rid of mysql traces: ```ruby Datadog::Tracing.before_flush( Datadog::Tracing::Pipeline::SpanFilter.new { |span| span.name != "mysql2.query" || rand < 0.5 }, )...
My confusion with `Datadog::Tracing::Pipeline::SpanFilter` is that the docs are inverted: they say that if the block returns true, **the span is kept**, when it's actually the opposite: https://github.com/DataDog/dd-trace-rb/blob/master/lib/datadog/tracing/pipeline/span_filter.rb#L7-L14
Thank you so much for your work here. I'd love if we can get this merged. Apple Calendar feeds use `BYSETPOS` when selecting a day of the month. And there...
@eileencodes could we merge this one please?
I think it's not uncommon to extend `ActionController::Base` with global controller behavior, even if it's not a great pattern. I imagine the original implementation was based on checking the value...
That's a great idea. Please go for it 🙏
Thanks @ohthatjames. Thanks for reporting. `console1984` currently only supports IRB, which is what we use at 37signals. I would be happy to welcome a PR adding support for `pry` too.
I like the idea @olivier-thatch 👍