Jordan Brough

Results 23 issues of Jordan Brough

@rdy putting this out there to get your thoughts on it. We've been using this and it's been really handy for a couple custom things. Lmk what you think and...

needs tests

## Description I noticed duplicate `ContactInbox`s being created and I believe this may be the reason. If this looks correct, I noticed some other areas that might need the same...

PR: unreviewed

This reverts a change from https://github.com/chatwoot/chatwoot/pull/5055. The other fixes in #5055 look good, but I think this part doesn't do what was intended. `:phone_number.presence` is evaluated at class-definition time (not...

PR: unreviewed

We search for conversations by this attribute (e.g. in ReplyMailbox and CsatSurveyController) so it seems like we should have an index on it.

PR: unreviewed

The Ruby 2.6 & 2.7 tests seem to have suddenly become flaky: ![image](https://user-images.githubusercontent.com/23050/150836798-7cbba94c-889c-4115-b3b0-a302504133d4.png) I saw some failures like that in a couple of my PRs, that usually went away if...

bug

Ruby version: 3.0.3 Rails version: 6.1.6.1 Sidekiq / Pro / Enterprise version(s): 6.5.1 / 5.5.1 / n/a When I define the following in `config/routes.rb` in my Rails app: (Utilizing Sidekiq...

To clarify/emphasize that this is a persistent state.

**Problem description** When viewing the git blame on a long file, I can't search for text in the file. If I type "command+F" Sublime Merge switches into 'search for commit'...

Just a suggestion: It could be good for visibility to add rtx to this page? https://github.com/rbenv/rbenv/wiki/Comparison-of-version-managers

documentation

I think it'd be helpful to improve the output of records in a Rails console when some of the fields have very long values. As of IRB version 1.3.1 (released...

activerecord