fixture_builder icon indicating copy to clipboard operation
fixture_builder copied to clipboard

Published 20 hours ago • verified publisher icon rdy

Simplify fixture generation and add customization hooks

Open jordan-brough opened this issue 8 years ago • 7 comments

@rdy putting this out there to get your thoughts on it. We've been using this and it's been really handy for a couple custom things. Lmk what you think and I can add some tests if it seems OK.

  • Always use ActiveRecord instead of only when we happen to be able to constantize the name.
  • Add select_scope_proc for custom record selection
  • Add hashize_record_proc for custom serialization
  • Use attributes_before_type_cast

jordan-brough avatar Mar 25 '16 17:03 jordan-brough

Let me look this over, I've been a little busy this week but I will make it a priority. I plan on fixing the Travis build issues first.

rdy avatar Apr 03 '16 16:04 rdy

Please rebase the branch of master to fix the Travis issues

rdy avatar Apr 04 '16 00:04 rdy

@rdy I've rebased and the tests are now green. Let me know what you think in general and if it seems OK I can add tests to cover the new functionality.

jordan-brough avatar Apr 04 '16 19:04 jordan-brough

@rdy ping :)

jordan-brough avatar Apr 22 '16 03:04 jordan-brough

I'll try to merge this by the weekend. If you don't mind adding tests for the new functionality I would be more inclined to merge the request quickly.

rdy avatar Apr 28 '16 03:04 rdy

Super! I'll add some tests in the next few days and then ping you for a merge. I just wanted to make sure you were OK with the idea before I spent the extra effort. Thanks!

jordan-brough avatar May 01 '16 06:05 jordan-brough

@jordan-brough If you add tests, we can look at testing and merging this.

thewoolleyman avatar Dec 24 '16 06:12 thewoolleyman